feat: support for tools in HuggingFaceAPIChatGenerator
#120
+963
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 11456907558Details
💛 - Coveralls |
anakin87
commented
Oct 18, 2024
haystack_experimental/components/generators/chat/hugging_face_api.py
Outdated
Show resolved
Hide resolved
shadeMe
requested changes
Oct 21, 2024
haystack_experimental/components/generators/chat/hugging_face_api.py
Outdated
Show resolved
Hide resolved
shadeMe
requested changes
Oct 22, 2024
shadeMe
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
I'm adding support for tools in
HuggingFaceAPIChatGenerator. Similar to OpenAI PR #57.How did you test it?
CI, new tests.
Notes for the reviewer
Don't be frightened by this large PR. Most of the code is tests.
Support for tools in the HF API/TGI is still experimental and not fully polished. This means the model in its own could work better than called via HF API/run in a TGI container. Examples: the model, if provided with tools, always tend to prepare tool calls; some models (Mistral) are not completely well supported.
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.